Code review comment for lp:~julien-spautz/granite/undo-close-tab

Revision history for this message
xapantu (xapantu) wrote :

It looks good. However, I think that adding a tab member to the Tab class is not necessary and may be confusing. If you want to attach some data to a GObject, you can use the builtin set_data functions.

But apart from that, it looks great, so, I'll remove that and adapt the code in the demo before merging. Good work!

review: Approve

« Back to merge proposal