Merge lp:~julie-w/unifield-server/US-6626 into lp:unifield-server

Proposed by jftempo
Status: Merged
Merged at revision: 5604
Proposed branch: lp:~julie-w/unifield-server/US-6626
Merge into: lp:unifield-server
Diff against target: 47 lines (+7/-5)
2 files modified
bin/addons/register_accounting/account_bank_statement.py (+3/-3)
bin/addons/register_accounting/wizard/wizard_cash_return.py (+4/-2)
To merge this branch: bzr merge lp:~julie-w/unifield-server/US-6626
Reviewer Review Type Date Requested Status
UniField Reviewer Team Pending
Review via email: mp+378503@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/addons/register_accounting/account_bank_statement.py'
--- bin/addons/register_accounting/account_bank_statement.py 2019-10-30 16:33:21 +0000
+++ bin/addons/register_accounting/account_bank_statement.py 2020-02-04 10:20:44 +0000
@@ -1796,7 +1796,7 @@
1796 """1796 """
1797 If the statement line...1797 If the statement line...
1798 - is being hardposted1798 - is being hardposted
1799 - has a Partner Third Party1799 - has a Partner Third Party being neither Intermission nor Intersection
1800 - is booked on an income or expense account1800 - is booked on an income or expense account
1801 ... this method creates automated entries on partner payable or receivable account (JI), adds them to the1801 ... this method creates automated entries on partner payable or receivable account (JI), adds them to the
1802 regline JE, and returns a list of their ids that will have to be reconciled once the JE will be posted.1802 regline JE, and returns a list of their ids that will have to be reconciled once the JE will be posted.
@@ -1806,8 +1806,8 @@
1806 if not st_line:1806 if not st_line:
1807 return False1807 return False
1808 automated_entries_ids = []1808 automated_entries_ids = []
1809 if posttype == 'hard' and st_line.partner_id and st_line.account_id.user_type.code in ('expense', 'income') and \1809 if posttype == 'hard' and st_line.partner_id and st_line.partner_id.partner_type not in ('intermission', 'section') and \
1810 st_line.direct_invoice is False:1810 st_line.account_id.user_type.code in ('expense', 'income') and st_line.direct_invoice is False:
1811 # Prepare some elements1811 # Prepare some elements
1812 move_line_obj = self.pool.get('account.move.line')1812 move_line_obj = self.pool.get('account.move.line')
1813 current_date = time.strftime('%Y-%m-%d')1813 current_date = time.strftime('%Y-%m-%d')
18141814
=== modified file 'bin/addons/register_accounting/wizard/wizard_cash_return.py'
--- bin/addons/register_accounting/wizard/wizard_cash_return.py 2020-01-21 17:24:12 +0000
+++ bin/addons/register_accounting/wizard/wizard_cash_return.py 2020-02-04 10:20:44 +0000
@@ -926,7 +926,8 @@
926 if partner:926 if partner:
927 if partner._name == 'res.partner':927 if partner._name == 'res.partner':
928 partner_id = partner.id928 partner_id = partner.id
929 advances_with_supplier.setdefault(adv_move, []).append(advance)929 if partner.partner_type not in ('intermission', 'section'):
930 advances_with_supplier.setdefault(adv_move, []).append(advance)
930 elif partner._name == 'hr.employee':931 elif partner._name == 'hr.employee':
931 line_employee_id = partner.id932 line_employee_id = partner.id
932 debit = abs(advance.amount)933 debit = abs(advance.amount)
@@ -945,7 +946,8 @@
945 account_id, debit, credit, adv_return_ref, adv_move, distrib_id, context=context)946 account_id, debit, credit, adv_return_ref, adv_move, distrib_id, context=context)
946 adv_move_data.append((adv_move, adv_id))947 adv_move_data.append((adv_move, adv_id))
947948
948 # if advance lines have a Partner Third Party: create Payable Entries and add them to the advance closing JE949 # if advance lines have a Partner Third Party being neither Intermission nor Intersection:
950 # create Payable Entries and add them to the advance closing JE
949 to_reconcile = {} # per advance line951 to_reconcile = {} # per advance line
950 payable_lines = []952 payable_lines = []
951 for adv_move in advances_with_supplier:953 for adv_move in advances_with_supplier:

Subscribers

People subscribed via source and target branches