Code review comment for lp:~juliank/ubuntu/bionic/apport/snap

Revision history for this message
Brian Murray (brian-murray) wrote :

This looks good to me now although we should open a bug about

 809 # executable?
 810 elif '/' in self.args[0]:
 811 pkg = apport.packaging.get_file_package(self.args[0])
 812 if not pkg:
 813 optparser.error('%s does not belong to a package.' % self.args[0])
 814 sys.exit(1)

not working with snaps.

review: Approve

« Back to merge proposal