Merge ~juliank/grub/+git/ubuntu:ubuntu into ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu

Proposed by Julian Andres Klode
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 913744107e433c266b8b6c832f6172420321f4dd
Merged at revision: 913744107e433c266b8b6c832f6172420321f4dd
Proposed branch: ~juliank/grub/+git/ubuntu:ubuntu
Merge into: ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu
Diff against target: 105 lines (+53/-3)
5 files modified
debian/.git-dpm (+2/-2)
debian/changelog (+8/-0)
debian/patches/series (+1/-0)
debian/patches/shorter_version_info.patch (+39/-0)
grub-core/normal/main.c (+3/-1)
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Review via email: mp+337338@code.launchpad.net

Description of the change

Show the upstream version only in the screen, and hide the rest in a package_version variable for bug 1723434.

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks good. Feel free to merge this and upload.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/.git-dpm b/debian/.git-dpm
2index f89b787..8a85ef0 100644
3--- a/debian/.git-dpm
4+++ b/debian/.git-dpm
5@@ -1,6 +1,6 @@
6 # see git-dpm(1) from git-dpm package
7-18e6620996821d33d36fc71cff2d5862ed24dfd8
8-18e6620996821d33d36fc71cff2d5862ed24dfd8
9+2682d074012bffc6242d607745fafe0bc4d209dc
10+2682d074012bffc6242d607745fafe0bc4d209dc
11 0992ffbac6a1b4c97c350d12e5301e0067daa0d6
12 0992ffbac6a1b4c97c350d12e5301e0067daa0d6
13 grub2_2.02.orig.tar.xz
14diff --git a/debian/changelog b/debian/changelog
15index b0c12de..97e2c79 100644
16--- a/debian/changelog
17+++ b/debian/changelog
18@@ -1,3 +1,11 @@
19+grub2 (2.02-2ubuntu7) UNRELEASED; urgency=medium
20+
21+ * debian/patches/shorter_version_info.patch: Only show the upstream version
22+ in menu and console, and hide the package one in a package_version
23+ variable. (LP: #1723434)
24+
25+ -- Julian Andres Klode <juliank@ubuntu.com> Thu, 08 Feb 2018 10:50:56 +0100
26+
27 grub2 (2.02-2ubuntu6) bionic; urgency=medium
28
29 [ Steve Langasek ]
30diff --git a/debian/patches/series b/debian/patches/series
31index 8142c1a..881bbcf 100644
32--- a/debian/patches/series
33+++ b/debian/patches/series
34@@ -73,3 +73,4 @@ dont-fail-efi-warnings.patch
35 tsc_efi_default_to_pmtimer.patch
36 mkconfig_keep_native_term_active.patch
37 bufio_sensible_block_sizes.patch
38+shorter_version_info.patch
39diff --git a/debian/patches/shorter_version_info.patch b/debian/patches/shorter_version_info.patch
40new file mode 100644
41index 0000000..c040d20
42--- /dev/null
43+++ b/debian/patches/shorter_version_info.patch
44@@ -0,0 +1,39 @@
45+From 2682d074012bffc6242d607745fafe0bc4d209dc Mon Sep 17 00:00:00 2001
46+From: Julian Andres Klode <julian.klode@canonical.com>
47+Date: Thu, 8 Feb 2018 10:48:37 +0100
48+Subject: Show only upstream version, hide rest in package_version variable
49+
50+The complete package version can get a bit long, so only show the
51+upstream version in the menu and on the top of the console, and
52+hide the complete version in a package_version variable.
53+
54+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1723434
55+Last-Updated: 2018-02-08
56+
57+Patch-Name: shorter_version_info.patch
58+---
59+ grub-core/normal/main.c | 4 +++-
60+ 1 file changed, 3 insertions(+), 1 deletion(-)
61+
62+diff --git a/grub-core/normal/main.c b/grub-core/normal/main.c
63+index e924f6448..4a6b3bff0 100644
64+--- a/grub-core/normal/main.c
65++++ b/grub-core/normal/main.c
66+@@ -208,7 +208,7 @@ grub_normal_init_page (struct grub_term_output *term,
67+
68+ grub_term_cls (term);
69+
70+- msg_formatted = grub_xasprintf (_("GNU GRUB version %s"), PACKAGE_VERSION);
71++ msg_formatted = grub_xasprintf (_("GNU GRUB version %s"), VERSION);
72+ if (!msg_formatted)
73+ return;
74+
75+@@ -560,6 +560,8 @@ GRUB_MOD_INIT(normal)
76+ grub_env_export ("grub_cpu");
77+ grub_env_set ("grub_platform", GRUB_PLATFORM);
78+ grub_env_export ("grub_platform");
79++
80++ grub_env_set ("package_version", PACKAGE_VERSION);
81+
82+ grub_boot_time ("Normal module prepared");
83+ }
84diff --git a/grub-core/normal/main.c b/grub-core/normal/main.c
85index e924f64..4a6b3bf 100644
86--- a/grub-core/normal/main.c
87+++ b/grub-core/normal/main.c
88@@ -208,7 +208,7 @@ grub_normal_init_page (struct grub_term_output *term,
89
90 grub_term_cls (term);
91
92- msg_formatted = grub_xasprintf (_("GNU GRUB version %s"), PACKAGE_VERSION);
93+ msg_formatted = grub_xasprintf (_("GNU GRUB version %s"), VERSION);
94 if (!msg_formatted)
95 return;
96
97@@ -560,6 +560,8 @@ GRUB_MOD_INIT(normal)
98 grub_env_export ("grub_cpu");
99 grub_env_set ("grub_platform", GRUB_PLATFORM);
100 grub_env_export ("grub_platform");
101+
102+ grub_env_set ("package_version", PACKAGE_VERSION);
103
104 grub_boot_time ("Normal module prepared");
105 }

Subscribers

People subscribed via source and target branches