Merge ~juliank/britney/+git/britney2-ubuntu:time-t into ~ubuntu-release/britney/+git/britney2-ubuntu:master

Proposed by Julian Andres Klode
Status: Merged
Merged at revision: bc3a6226ffd3372cb03d7b6383260e329956670f
Proposed branch: ~juliank/britney/+git/britney2-ubuntu:time-t
Merge into: ~ubuntu-release/britney/+git/britney2-ubuntu:master
Diff against target: 15 lines (+4/-0)
1 file modified
britney2/policies/autopkgtest.py (+4/-0)
Reviewer Review Type Date Requested Status
Canonical's Ubuntu QA Pending
Ubuntu Release Team Pending
Review via email: mp+462607@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Julian Andres Klode (juliank) wrote (last edit ):

vs somehow doing it in autopkgtest cloud for each armhf request

Pro:

- this unblocks uploads happening now
- it actually adds all-proposed to the request so it shows up in the log
- as a result of the previous, retry-autopkgtest-regressions with --all-proposed works correctly

Cons:

- doesn't handle retries without all-proposed automagically

To solve the con or at least mostly (the checking for running tests in the client part is broken if you don't use --all-proposed), suggest Ubuntu QA to patch autopkgtest-cloud's webcontrol/request/submit.py to also insert all-proposed for noble armhf requests.

Revision history for this message
Julian Andres Klode (juliank) wrote :
Revision history for this message
Julian Andres Klode (juliank) wrote :

v3: We now automatically expire on Apr 4.

Revision history for this message
Tim Andersson (andersson123) wrote :

For the record now, the autopkgtest-cloud side of things is patched as julian mentioned and deployed already.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/britney2/policies/autopkgtest.py b/britney2/policies/autopkgtest.py
2index c5098d6..476c132 100644
3--- a/britney2/policies/autopkgtest.py
4+++ b/britney2/policies/autopkgtest.py
5@@ -1131,6 +1131,10 @@ class AutopkgtestPolicy(BasePolicy):
6 qname = 'debci-huge-%s-%s' % (self.options.series, arch)
7 else:
8 qname = 'debci-%s-%s' % (self.options.series, arch)
9+ # FIXME: Remove after the time_t transition
10+ if (arch == "armhf" and self.options.series == "noble" and
11+ datetime.utcnow() < datetime.date(2024, 4, 4)):
12+ params["all-proposed"] = "1"
13 params['submit-time'] = datetime.strftime(datetime.utcnow(), '%Y-%m-%d %H:%M:%S%z')
14
15 if self.amqp_channel:

Subscribers

People subscribed via source and target branches