Code review comment for ~juliank/britney/+git/britney2-ubuntu:lp1688516

Revision history for this message
Iain Lane (laney) wrote :

Basic approach is good, thanks!

As discussed, we should handle the multiple hint case differently: find the highest version that is at most the current trigger and look at that one. If there are multiple versions in play - a version in testing and a version (possibly this is one of many uploads!) in unstable, we want to be able to hint them independently.

I think an 'excuse' should be added so that it's clear on update_excuses.html that a test is only ALWAYSFAIL because it's been hinted - for force-skiptest we say "Should wait for tests relating to %s %s, but forced by %s". Our string could be very similar.

Does /arch work and can we have a test for that?

« Back to merge proposal