Merge ~juliank/autopkgtest-cloud:migration-reference-0 into autopkgtest-cloud:master

Proposed by Julian Andres Klode
Status: Merged
Merged at revision: 8a3b1c66ebff684ff7663ea5c6335fd1ac1c655d
Proposed branch: ~juliank/autopkgtest-cloud:migration-reference-0
Merge into: autopkgtest-cloud:master
Diff against target: 49 lines (+12/-4)
2 files modified
charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker (+5/-2)
charms/focal/autopkgtest-web/webcontrol/request/submit.py (+7/-2)
Reviewer Review Type Date Requested Status
Steve Langasek Needs Information
Review via email: mp+411450@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) :
review: Needs Information

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker
2index 8384446..ed98b44 100755
3--- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker
4+++ b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker
5@@ -648,10 +648,13 @@ def request(msg):
6 if 'test-git' not in params and 'test-bzr' not in params and ('ppas' not in params or 'all-proposed' in params):
7 pocket_arg = '--apt-pocket=proposed'
8 if 'all-proposed' not in params and not pkgname.startswith('linux'):
9- trigs = ['src:' + t.split('/', 1)[0] for t in params.get('triggers', [])]
10+ trigs = ['src:' + t.split('/', 1)[0] for t in params.get('triggers', []) if t != 'migration-reference/0']
11 if trigs:
12 pocket_arg += '=' + ','.join(trigs)
13- argv.append(pocket_arg)
14+ else:
15+ pocket_arg = ""
16+ if pocket_arg:
17+ argv.append(pocket_arg)
18 argv.append('--apt-upgrade')
19
20 # determine which test to run
21diff --git a/charms/focal/autopkgtest-web/webcontrol/request/submit.py b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
22index 763be5d..56742e1 100644
23--- a/charms/focal/autopkgtest-web/webcontrol/request/submit.py
24+++ b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
25@@ -114,6 +114,11 @@ class Submit:
26 # Debian Policy 5.6.1 and 5.6.12
27 if not NAME.match(trigsrc) or not VERSION.match(trigver):
28 raise ValueError('Malformed trigger')
29+
30+ # Special snowflake
31+ if trigger == 'migration-reference/0':
32+ continue
33+
34 if ppas:
35 if not self.is_valid_package_version(release, trigsrc, trigver,
36 ppas and ppas[-1] or None):
37@@ -355,10 +360,10 @@ class Submit:
38 person, release, component, package, code, repr(response))
39 return code >= 200 and code < 300
40
41- def in_allowed_team(self, person, package=[]):
42+ def in_allowed_team(self, person, package=[], teams=[]):
43 """Check if person is in ALLOWED_TEAMS"""
44
45- for team in ALLOWED_TEAMS:
46+ for team in (teams or ALLOWED_TEAMS):
47 (code, response) = self.lp_request('~%s/participants' % team, {})
48 for e in response.get('entries', []):
49 if e.get('name') == person:

Subscribers

People subscribed via source and target branches