Merge ~juliank/autopkgtest-cloud:request-cgi-sort-params into autopkgtest-cloud:master

Proposed by Julian Andres Klode
Status: Merged
Merged at revision: 47f9c6188451336e99ab63d19430a1047254d6c3
Proposed branch: ~juliank/autopkgtest-cloud:request-cgi-sort-params
Merge into: autopkgtest-cloud:master
Diff against target: 13 lines (+1/-1)
1 file modified
webcontrol/request/app.py (+1/-1)
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+363916@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

thanks Julian!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/webcontrol/request/app.py b/webcontrol/request/app.py
2index 98d4acd..77e4c7d 100644
3--- a/webcontrol/request/app.py
4+++ b/webcontrol/request/app.py
5@@ -217,7 +217,7 @@ def index_root():
6 params['package'], params['release'], params['arch'])
7 params['Result history'] = '<a href="{}">{}</a>'.format(url, url)
8 success = SUCCESS.format(
9- EMPTY.join(ROW.format(key, val) for key, val in params.items())
10+ EMPTY.join(ROW.format(key, val) for key, val in sorted(params.items()))
11 )
12 return HTML.format(LOGOUT + success).format(
13 **ChainMap(session, params))

Subscribers

People subscribed via source and target branches