Launchpad Dependencies

Merge lp:~julian-edwards/meta-lp-deps/add-rabbit-management into lp:meta-lp-deps

  1. add-rabbit-management
  2. Merge into trunk
Proposed by Julian Edwards
Status: Rejected
Rejected by: Julian Edwards
Proposed branch: lp:~julian-edwards/meta-lp-deps/add-rabbit-management
Merge into: lp:meta-lp-deps
Diff against target: 27 lines (+8/-1)
2 files modified
debian/changelog (+7/-0)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~julian-edwards/meta-lp-deps/add-rabbit-management
Reviewer Review Type Date Requested Status
Steve Kowalik (community) code Disapprove
Review via email: mp+78930@code.launchpad.net

Description of the change

Depend on specific versions of rabbit and its management plugin that live in the Launchpad PPA so that the LOSAs get the right versions installed in production because Lucid is on 1.7.2-1ubuntu1.

To post a comment you must log in.
Revision history for this message
Steve Kowalik (stevenk) wrote :

Both versions you're depending on are greater than what Lucid provides. If CAT has the right versions, this is entirely unnecessary and I would prefer it did not land.

review: Disapprove (code)
Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Wednesday 12 October 2011 01:58:17 you wrote:
> Review: Disapprove code
>
> Both versions you're depending on are greater than what Lucid
 provides. If
> CAT has the right versions, this is entirely unnecessary and I
 would prefer
> it did not land.

Yeah, I've already talked about this with William and he pointed
out the same thing. It's what you get for me not being a
packager :)

Cheers.

Unmerged revisions

128. By Julian Edwards

Depend on specific versions of rabbit and its management plugin that live in the Launchpad PPA.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-09-30 11:52:14 +0000
3+++ debian/changelog 2011-10-11 09:20:35 +0000
4@@ -1,3 +1,10 @@
5+launchpad-dependencies (0.101) oneiric; urgency=high
6+
7+ * Depend on specific versions of rabbit and its management plugin that
8+ live in the Launchpad PPA.
9+
10+ -- Julian Edwards <julian.edwards@canonical.com> Tue, 11 Oct 2011 10:13:46 +0100
11+
12 launchpad-dependencies (0.100) oneiric; urgency=low
13
14 * Add rabbitmq-management as a depedency on
15
16=== modified file 'debian/control'
17--- debian/control 2011-09-23 10:28:33 +0000
18+++ debian/control 2011-10-11 09:20:35 +0000
19@@ -77,7 +77,7 @@
20
21 Package: launchpad-messagequeue-dependencies
22 Architecture: all
23-Depends: python-amqplib, rabbitmq-server, stunnel4, rabbitmq-management
24+Depends: python-amqplib, rabbitmq-server (>= 2.3.1-1ubuntu1~lucid1~ppa1), stunnel4, rabbitmq-management (>=2.3.1+hg20110202-0ppa5)
25 ${misc:Depends}
26 Description: Meta-package for Launchpad messagequeue packages
27 This meta-package depends on all of the packages necessary to run a Launchpad

Subscribers

People subscribed via source and target branches