Code review comment for lp:~julian-edwards/maas/ui-fixes

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Thanks for reviewing.

On 18/06/14 17:48, Jeroen T. Vermeulen wrote:
> Review: Approve
>
> Thanks for fixing this. I believe there's a MAC field that gets displayed as Mac as well... I might just do that next when I have time to fill.
>
> The router_ip help string says “IP of this network's router given to DHCP clients” — should that be _to be_ given to DHCP clients?

I think that's more wordy and essentially makes no difference to the
reader's understanding of what will happen.

>
> Does it need saying that the static and dynamic ranges must be disjoint?
>

Well if they are not disjoint the user will quickly find out about that :)

But you raise an interesting point that I was pondering over anyway -
where do we put general help text for the whole form? We don't have a
good way of doing this AFAIK.

« Back to merge proposal