Merge lp:~julian-edwards/maas/stop-dhcp-bug-1059459 into lp:~maas-maintainers/maas/packaging

Proposed by Julian Edwards
Status: Merged
Approved by: Julian Edwards
Approved revision: 112
Merged at revision: 111
Proposed branch: lp:~julian-edwards/maas/stop-dhcp-bug-1059459
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 61 lines (+25/-1)
4 files modified
debian/changelog (+16/-1)
debian/extras/isc-dhcp-server.override (+1/-0)
debian/maas-cluster-controller.install (+1/-0)
debian/maas-dhcp.postinst (+7/-0)
To merge this branch: bzr merge lp:~julian-edwards/maas/stop-dhcp-bug-1059459
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+127418@code.launchpad.net

Commit message

Ensure that the ISC DHCP server is stopped and disabled when installing maas-dhcp.

Description of the change

This packaging change ensures that the ISC DHCP server is stopped and disabled when installing maas-dhcp.

Pre-imped with Andres and QAed locally.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Self reviewing since Andres gave it the thumbs up and I also tested it already.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-10-01 07:15:35 +0000
3+++ debian/changelog 2012-10-02 05:50:23 +0000
4@@ -1,7 +1,22 @@
5-maas (0.1+bzr1116+dfsg-0ubuntu1) quantal; urgency=low
6+maas (0.1+bzr1122+dfsg-0ubuntu1) UNRELEASED; urgency=low
7
8 * New upstream release.
9
10+ [ Julian Edwards ]
11+ * Ensure isc-dhcp-server is disabled when installing maas-dhcp.
12+
13+ [ Raphaƫl Badin ]
14+ * Split celery config into cluster and region configs.
15+ * Add region celeryd upstart config.
16+ * Define CELERY_CONFIG_MODULE in
17+ maas-cluster-controller.maas-cluster-celery.upstart
18+
19+ [ Jeroen Vermeulen ]
20+ * Make maas_local_celery_config.py non-world readable.
21+ * Make maas_local_celeryconfig_cluster.py non-world readable.
22+ * Set root:maas ownership of local cluster config only *after*
23+ the maas user/group have been created
24+
25 -- Julian Edwards <julian.edwards@canonical.com> Mon, 01 Oct 2012 17:13:57 +1000
26
27 maas (0.1+bzr1110+dfsg-0ubuntu1) quantal; urgency=low
28
29=== added file 'debian/extras/isc-dhcp-server.override'
30--- debian/extras/isc-dhcp-server.override 1970-01-01 00:00:00 +0000
31+++ debian/extras/isc-dhcp-server.override 2012-10-02 05:50:23 +0000
32@@ -0,0 +1,1 @@
33+manual
34
35=== modified file 'debian/maas-cluster-controller.install'
36--- debian/maas-cluster-controller.install 2012-09-29 17:21:10 +0000
37+++ debian/maas-cluster-controller.install 2012-10-02 05:50:23 +0000
38@@ -16,3 +16,4 @@
39 # Install all other stuff
40 debian/extras/99-maas-sudoers etc/sudoers.d
41 debian/extras/maas-provision usr/sbin
42+debian/extras/isc-dhcp-server.override etc/init
43
44=== modified file 'debian/maas-dhcp.postinst'
45--- debian/maas-dhcp.postinst 2012-09-27 05:23:12 +0000
46+++ debian/maas-dhcp.postinst 2012-10-02 05:50:23 +0000
47@@ -3,7 +3,14 @@
48 . /usr/share/debconf/confmodule
49 db_version 2.0
50
51+stop_isc_dhcp_server(){
52+ service isc_dhcp_server stop
53+}
54+
55+
56 if [ "$1" = "configure" ]; then
57+ stop_isc_dhcp_server
58+
59 dhcpd_prof="/etc/apparmor.d/usr.sbin.dhcpd"
60 if [ -f "${dhcpd_prof}" ] &&
61 command -v apparmor_parser >/dev/null 2>&1; then

Subscribers

People subscribed via source and target branches