Code review comment for lp:~julian-edwards/maas/rndc-crash-bug-1386488

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Wednesday 29 Oct 2014 07:36:57 you wrote:
> Ultimately, when NodeActionErrors are caught (in the form from which the
> action originated), the error's message is added to the UI as a warning.
> In this case, you might see something like:
>
> "Command `rndc -c /etc/bind/maas/rndc.conf.maas reload maas` returned
> non-zero exit status 1: rndc: 'reload' failed: dynamic zone"
>
> In the UI.
>
> Actually, that's not so terrible (in that it can then be reported to an
> admin, or the admin can go and fix it… I wonder if we shouldn't be
> sanitising some of those kind of messages for non-admins, though. Not,
> however, a concern for this branch; just a rambly 7:30am thought.

I think that given the likelihood of this error ever happening I don't mind
dumping the whole thing there. If a user sees it, they'll just grab an
operator/admin and report what they see, which is actually very useful.

Cheers, thanks for the review!

« Back to merge proposal