Code review comment for lp:~julian-edwards/maas/request-user-ip
Revision history for this message
| Julian Edwards (julian-edwards) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
On Thursday 11 Sep 2014 05:42:49 you wrote:
> Review: Approve
>
> I can see why you might return an HTTP status code of Forbidden for an
> address that wasn't in the right range, but Not Found for an address that's
> already taken seems strange. Isn't this a classic case for the Conflict
> error?
I am following what I did in the similar change in the claim_sticky_ip stuff.
There is a good reason, conflict is wrong IMO. If I can find the original MP
I'll show you later.
Thanks for the review!