MAAS

Code review comment for lp:~julian-edwards/maas/request-user-ip

  1. request-user-ip
  2. Merge into trunk
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

I can see why you might return an HTTP status code of Forbidden for an address that wasn't in the right range, but Not Found for an address that's already taken seems strange. Isn't this a classic case for the Conflict error?

review: Approve

« Back to merge proposal