Code review comment for lp:~julian-edwards/maas/race-for-staticip-bug-1387262
Revision history for this message
| Julian Edwards (julian-edwards) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
On Wednesday 05 Nov 2014 04:22:23 you wrote:
> I assume you are using two calls to assertThat instead of expectThat because
> if the lock was not acquired then you know it wouldn't have been released,
> correct? I.e., you can't get the second test to error unless the first one
> passes. This stood out to me and I had to ask because I know you love
> expectThat!
Correct :)