Code review comment for lp:~julian-edwards/maas/pserv-services-dir

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Thank you!

On Wednesday 27 Aug 2014 04:02:05 you wrote:
> Review: Approve
>
> Your revulsion at the __init__.py services situation is noted. Now please
> drop that README file and just live with the new name!

I wrote that in a fit of pique. I'll get rid of it.

> (For the record, what bugs me most about the new name is probably that the
> "serv" and the "services" repeat the same root.)

Yes. All of the yes.

> For the XXX in node_power_monitor_service.py, could you file a bug and
> include its number in the comment?

Yes. I forgot to do that.

> I see you preserved the "one_week_ago = er, 15 minutes ago" sickness. That
> makes my review easier (no need to look for changes in the moved code) but
> I hope we'll get rid of that soon as well.

Yeah deliberately so, I didn't want to touch the code at all. The next change
can fix it, pending my questions about it in Blake's last merge.

« Back to merge proposal