MAAS

Code review comment for lp:~julian-edwards/maas/pserv-services-dir

  1. pserv-services-dir
  2. Merge into trunk
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Your revulsion at the __init__.py services situation is noted. Now please drop that README file and just live with the new name!

(For the record, what bugs me most about the new name is probably that the "serv" and the "services" repeat the same root.)

.

For the XXX in node_power_monitor_service.py, could you file a bug and include its number in the comment?

.

I see you preserved the "one_week_ago = er, 15 minutes ago" sickness. That makes my review easier (no need to look for changes in the moved code) but I hope we'll get rid of that soon as well.

review: Approve

« Back to merge proposal