Merge lp:~julian-edwards/maas/packaging into lp:~maas-maintainers/maas/packaging

Proposed by Julian Edwards
Status: Merged
Approved by: Julian Edwards
Approved revision: no longer in the source branch.
Merged at revision: 239
Proposed branch: lp:~julian-edwards/maas/packaging
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 121 lines (+28/-9)
8 files modified
debian/changelog (+14/-2)
debian/control (+2/-0)
debian/extras/maas (+4/-0)
debian/maas-cli.install (+1/-1)
debian/maas-cli.links (+1/-0)
debian/maas-dns.postinst (+2/-2)
debian/maas-region-controller-min.install (+1/-1)
debian/maas-region-controller.postinst (+3/-3)
To merge this branch: bzr merge lp:~julian-edwards/maas/packaging
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Jeroen T. Vermeulen (community) Approve
Review via email: mp+205901@code.launchpad.net

Commit message

Rename maas to maas-region-admin, and maas-cli to maas.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

A daring thrust. It looks good to me, although I'm sure I'll be forgetting something. Ultimately only experience will tell.

review: Approve
Revision history for this message
Andres Rodriguez (andreserl) wrote :

Hey Julian,

There will be an upgrade issue given that previous maas-region-controller-min installs 'maas' and now 'maas-cli' installs the MAAS binary. A Conflict/Replaces in maas-cli is needed against the latest version maas-region-controller-min that's shipping 'maas'.

review: Needs Fixing
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm! Let's just get this tested!

review: Approve
Revision history for this message
Julian Edwards (julian-edwards) wrote :

I had to fix the maas-cli match with some crazy expr code (unless you want to move the script to use bash, where it's much easier!)

lp:~julian-edwards/maas/packaging updated
239. By Julian Edwards

[r=andreserl,jtv][bug=1052805][author=julian-edwards] Rename maas to maas-region-admin, and maas-cli to maas.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-02-11 15:46:25 +0000
3+++ debian/changelog 2014-02-13 05:31:25 +0000
4@@ -1,4 +1,4 @@
5-maas (1.5+bzr1909-0ubuntu2) UNRELEASED; urgency=low
6+maas (1.5+bzr1930-0ubuntu1) UNRELEASED; urgency=low
7
8 [ Graham Binns ]
9 * debian/control: Depends on python-jsonschema.
10@@ -7,7 +7,19 @@
11 * debian/maas-region-controller-min.posinst: Make txlongpoll.yaml only
12 readable by the app and not world readeable.
13
14- -- Andres Rodriguez <andreserl@ubuntu.com> Fri, 07 Feb 2014 18:24:08 -0500
15+ [ Julian Edwards ]
16+ * debian/extras/maas-cli renamed to debian/extras/maas, and introduce
17+ a deprecation warning in favour of using maas over maas-cli.
18+ * debian/extras/maas renamed to debian/extras/maas-region-admin
19+ * debian/maas-cli.install: install debian/extras/maas
20+ * debian/maas-dns.postinst: Invoke maas-region-admin instead of maas
21+ * debian/maas-region-controller-min.install: install maas-region-admin
22+ instead of maas
23+ * debian/maas-region-controller.postinst: Invoke maas-region-admin instead
24+ of maas
25+ * debian/maas-cli.links: Link from maas to maas-cli for backward compat.
26+
27+ -- Julian Edwards <julian.edwards@canonical.com> Wed, 12 Feb 2014 15:42:00 +1000
28
29 maas (1.5+bzr1909-0ubuntu1) trusty; urgency=low
30
31
32=== modified file 'debian/control'
33--- debian/control 2014-02-11 05:10:18 +0000
34+++ debian/control 2014-02-13 05:31:25 +0000
35@@ -153,6 +153,8 @@
36 python-oauth,
37 ${misc:Depends},
38 ${python:Depends}
39+Conflicts: maas-region-controller-min (<= 1.5+bzr1909-0ubuntu1)
40+Replaces: maas-region-controller-min (<= 1.5+bzr1909-0ubuntu1)
41 Description: Ubuntu MAAS Client Tool
42 Ubuntu MAAS Server is the successor to Orchestra. It offers a
43 nice UI to provision your Ubuntu servers. Each physical server
44
45=== renamed file 'debian/extras/maas-cli' => 'debian/extras/maas'
46--- debian/extras/maas-cli 2012-09-19 19:00:45 +0000
47+++ debian/extras/maas 2014-02-13 05:31:25 +0000
48@@ -1,2 +1,6 @@
49 #!/bin/sh
50+if [ "`expr \"$0\" : \".*maas-cli*\"`" != "0" ];then
51+ echo " WARNING: The maas-cli command is deprecated and will be removed" \
52+ "in a future\n version. From now on please use 'maas' instead."
53+fi
54 exec python -m maascli "$@"
55
56=== renamed file 'debian/extras/maas' => 'debian/extras/maas-region-admin'
57=== modified file 'debian/maas-cli.install'
58--- debian/maas-cli.install 2012-09-20 15:20:51 +0000
59+++ debian/maas-cli.install 2014-02-13 05:31:25 +0000
60@@ -1,2 +1,2 @@
61-debian/extras/maas-cli usr/bin
62+debian/extras/maas usr/bin
63 debian/tmp/usr/lib/python*/dist-packages/maascli
64
65=== added file 'debian/maas-cli.links'
66--- debian/maas-cli.links 1970-01-01 00:00:00 +0000
67+++ debian/maas-cli.links 2014-02-13 05:31:25 +0000
68@@ -0,0 +1,1 @@
69+usr/bin/maas usr/bin/maas-cli
70
71=== modified file 'debian/maas-dns.postinst'
72--- debian/maas-dns.postinst 2014-01-13 04:06:25 +0000
73+++ debian/maas-dns.postinst 2014-02-13 05:31:25 +0000
74@@ -5,7 +5,7 @@
75 if ([ "$1" = "configure" ] && [ -z "$2" ]) || [ -n "$DEBCONF_RECONFIGURE" ]; then
76 # If /etc/bind/maas is empty, set_up_dns.
77 if [ ! "$(ls -A /etc/bind/maas)" ]; then
78- maas set_up_dns
79+ maas-region-admin set_up_dns
80 fi
81
82 # Fix permissions.
83@@ -26,7 +26,7 @@
84 # Remove any existing MAAS-related include line from
85 # /etc/bind/named.conf.local, then re-add it.
86 sed -i '/^include\s.*maas/d' /etc/bind/named.conf.local
87- maas get_named_conf --edit --config_path /etc/bind/named.conf.local
88+ maas-region-admin get_named_conf --edit --config_path /etc/bind/named.conf.local
89
90 invoke-rc.d bind9 restart || true
91 fi
92
93=== modified file 'debian/maas-region-controller-min.install'
94--- debian/maas-region-controller-min.install 2013-12-02 22:19:41 +0000
95+++ debian/maas-region-controller-min.install 2014-02-13 05:31:25 +0000
96@@ -30,7 +30,7 @@
97 debian/tmp/etc/maas/templates/commissioning-user-data
98
99 # Install all other stuff
100-debian/extras/maas usr/sbin
101+debian/extras/maas-region-admin usr/sbin
102 debian/extras/maas-region-celeryd usr/sbin
103 debian/extras/20-maas.conf etc/rsyslog.d
104 debian/extras/maas_remote_syslog_compress etc/cron.d
105
106=== modified file 'debian/maas-region-controller.postinst'
107--- debian/maas-region-controller.postinst 2014-01-15 15:38:32 +0000
108+++ debian/maas-region-controller.postinst 2014-02-13 05:31:25 +0000
109@@ -12,9 +12,9 @@
110 RELEASE=`lsb_release -rs` || RELEASE=""
111
112 maas_sync_migrate_db(){
113- maas syncdb --noinput
114- maas migrate maasserver --noinput
115- maas migrate metadataserver --noinput
116+ maas-region-admin syncdb --noinput
117+ maas-region-admin migrate maasserver --noinput
118+ maas-region-admin migrate metadataserver --noinput
119 }
120
121 restart_rabbitmq(){

Subscribers

People subscribed via source and target branches