Code review comment for lp:~julian-edwards/maas/only-ready-when-power-is-off

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Monday 15 Sep 2014 07:22:08 you wrote:
> > I tested this locally and it seems to be ok, you can't start the node
> > again until the poweroff script finishes.
>
> What happens if powering the machine off fails? (if the template blows up or
> if the status of the node is never changed?) I'd say we need to introduce
> a RELEASING_FAILED state but I'd like to hear your thoughts on this.

It will be marked BROKEN; that's already all been done.

« Back to merge proposal