Code review comment for lp:~julian-edwards/maas/ntp-server-dhcp

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On 11/11/13 18:25, Graham Binns wrote:
> Review: Approve
>
> Minor nitpick, otherwise looks good.
>
> [1]
>
> + "e.g. 91.189.94.4 (ntp.ubuntu.com)")
>
> It's not clear from this what the example is. Should I copy just the IP, or the IP and what's inside the parens, or can I just use what's inside the parens?
>
> I'd say something like: "e.g. for ntp.ubuntu.com: '91.189.94.4'".

Good call, thanks. I was hand-wringing over that one a bit :)

« Back to merge proposal