MAAS

Code review comment for lp:~julian-edwards/maas/nicer-mac-address-error

  1. nicer-mac-address-error
  2. Merge into trunk
Revision history for this message
John A Meinel (jameinel) wrote :

I thought Validation error took a dict of {'variable': 'message'} so the exception should be:
ValueError({'macs': "Invalid MAC address(es): %s" % ", ".join(invalid_macs)})

Otherwise, good.

review: Approve

« Back to merge proposal