On Friday 05 September 2014 03:20:51 you wrote:
> Review: Approve
>
> Two nitpicks about this bit you're adding in the factory:
>
> if default_gateway is None and random.choice((True, False)):
> default_gateway = unicode(IPAddress(network.first + 1))
>
> The factory has a helper for random.choice((True, False)): pick_bool().
>
> Why are you forcing the gateway to be network.first + 1? I'd use
> self.pick_ip_in_network(network).
On Friday 05 September 2014 03:20:51 you wrote: choice( (True, False)): IPAddress( network. first + 1)) choice( (True, False)): pick_bool(). ip_in_network( network) .
> Review: Approve
>
> Two nitpicks about this bit you're adding in the factory:
>
> if default_gateway is None and random.
> default_gateway = unicode(
>
> The factory has a helper for random.
>
> Why are you forcing the gateway to be network.first + 1? I'd use
> self.pick_
Both good points, I'll change things, thank you!