Code review comment for lp:~julian-edwards/maas/more-docs

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Friday 11 Oct 2013 06:21:25 you wrote:
> Review: Approve
>
> Thanks. Good to see some attention being paid to documentation.
>
> “When using third party tools such as ``juju`` it will need to be able to
> resolve the hostnames” hobbles a bit — tools, plural, are suddenly an “it.”
> How about just “Third-party tools such as ``juju`` may need the ability to
> resolve the hostnames”?

Good spot.

> I suppose that note at the very end means that even if you could give a node
> multiple kernel-options tags, only an arbitrary one of them would actually
> be applied. Or are per-node kernel options combined? Worth a mention
> perhaps.

I think you are missing something here. It's talking about overriding the
global options, not multiple options per node. It remains clear even re-
reading it 2 hours after I wrote it.

« Back to merge proposal