Code review comment for lp:~julian-edwards/maas/ipmi-with-mac

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Well done for actually documenting your intentions. I guess the lookup of the IP address was already in there somewhere.

One thing that still makes me nervous is the "primary MAC" idea — what if an existing installation upgrades, has its power addresses changed, and now finds that a node's primary MAC wasn't on a network that talks to the cluster controller? Once we start auto-discovering networks, we can start making more informed choices.

review: Approve

« Back to merge proposal