Code review comment for lp:~julian-edwards/maas/import-fail-bug-1386914

Revision history for this message
Blake Rouse (blake-rouse) wrote :

> On Thursday 30 Oct 2014 15:46:23 you wrote:
> > There is an issue with this.
> >
> > The cache is only updated every hour. If an update occurs and it fails it
> > will show this error for a whole hour, until it tries again. The import
> > process does not update the cache its completely seperate, it doesn't even
> > us the cache, the cache is for the UI only.
>
> Ok this is useful info, thanks.
>
> > Only way I can think around this is to update the cache before each import,
> > if not then this error message can exist while it has imported and
> > completed successfully.
>
> That seems like something I'd expect to happen anyway, so great. Can you
> point me at the relevant area that needs changing?

You would need to start the update in maasserver/bootresources.py:_import_resources. If you do add this, then you probably could remove the cache updating service, since the importing is a service as well.

>
> Also would you please consider a technical overview write-up of this whole
> import process? It seems that a few of us don't fully understand the changes
> you made.

I will work on adding a doc in the dev section to give an overview of how it all works.

>
> J

« Back to merge proposal