Code review comment for lp:~julian-edwards/maas/enable_dhcp_when_setting_up_params

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Tuesday 04 September 2012 06:10:44 you wrote:
> Review: Approve
>
> Makes sense. One small thing: in that last test, it may help to disable
> manage_dhcp explicitly. If we ever decide to change the default, or
> there's another test isolation problem, it'll be good to know that the test
> isn't passing for the wrong reason.
>
>
> Jeroen

Good call, thanks.

« Back to merge proposal