Code review comment for lp:~julian-edwards/maas/download-service-exceptions

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Wednesday 27 August 2014 07:15:51 you wrote:
> Review: Approve
>
> Nicely done. Just one note: shouldn't the existing tests then call
> try_download instead of maybe_start_download, so that the success case is
> covered?

It's already doing that; it relies on the service itself calling the functions
in the service object.

Thanks for the review!

« Back to merge proposal