On Friday 05 September 2014 08:06:48 you wrote:
> Review: Approve
>
> About time to line-break that ‘fields’ tuple in networks.py properly, I
> think...
I can't see anything wrong with it.
> I'd be happy to know I was worried about nothing, but will this new field
> support both empty strings and nulls? It seems like a recipe for
> confusion, e.g. if we start doing things like “if no DNS servers have been
> set on this network that we manage, substitute the MAAS DNS server.” Does
> that go for nulls, or for blanks as well? Which do you get in API results?
> Probably worth being clear about.
AFAIK it stores blanks as NULL with those field settings.
Thanks for reviewing!
On Friday 05 September 2014 08:06:48 you wrote:
> Review: Approve
>
> About time to line-break that ‘fields’ tuple in networks.py properly, I
> think...
I can't see anything wrong with it.
> I'd be happy to know I was worried about nothing, but will this new field
> support both empty strings and nulls? It seems like a recipe for
> confusion, e.g. if we start doing things like “if no DNS servers have been
> set on this network that we manage, substitute the MAAS DNS server.” Does
> that go for nulls, or for blanks as well? Which do you get in API results?
> Probably worth being clear about.
AFAIK it stores blanks as NULL with those field settings.