Code review comment for lp:~julian-edwards/maas/dns-in-networks

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

About time to line-break that ‘fields’ tuple in networks.py properly, I think...

I'd be happy to know I was worried about nothing, but will this new field support both empty strings and nulls? It seems like a recipe for confusion, e.g. if we start doing things like “if no DNS servers have been set on this network that we manage, substitute the MAAS DNS server.” Does that go for nulls, or for blanks as well? Which do you get in API results? Probably worth being clear about.

Personally I would say “space-separated” rather than “space separated”; avoids grammatical ambiguity early on.

review: Approve

« Back to merge proposal