Code review comment for lp:~julian-edwards/maas/commissioning_error_check_bug_1239668
Revision history for this message
| Julian Edwards (julian-edwards) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Tuesday 15 Oct 2013 08:17:58 you wrote:
> Review: Approve
>
> This is fine, but needs QA. There may be parts of the script that return
> non-zero and have therefore been ignored so far (and seemingly don't
> matter...) but that will crash the script with -eu.
I agree! Which is why I will be doing exactly that very soon :)