Code review comment for lp:~julian-edwards/maas/better-search

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Monday 03 November 2014 16:00:34 you wrote:
> > When I change it to fix one browser, the other screws up. I think I need
> > some help here, if you are able?
> I don't see the overlap I was seeing last week, I guess you've fixed this.

I did. Copious overriding of CSS properties!

> The only UI problem that I see is the jumping magnifying glass… and the only
> way I managed to fix the problem is by doing this:

> http://paste.ubuntu.com/8804644/.

I worked out what's causing it in the end, I can just remove the padding in
the input that it's inheriting from some top-level CSS class. The hover makes
the padding move! Weird.

Also the other problem is that the input boxes are different lengths on FF and
Chrom*. FF increases the size of the box when you left-pad the text to make
room for the icon; Chrom* does not. Consistency eh?!

I need to fix one more thing too, the margins are different sizes on each box
(again, css inheritance...).

« Back to merge proposal