Code review comment for lp:~julian-edwards/maas/better-search

Revision history for this message
Raphaƫl Badin (rvb) wrote :

This looks good to me. This is a massive improvement to the usability of MAAS. I'm not entirely sure we should have the two search boxes though. It's looks weird and I'm not sure anyone uses the constraints search box since it isn't documented anywhere.

So I'd be +1 on removing it after we make sure its usage is non-existant. But this is something we can do after this lands.

>> Okay, then we shouldn't do this without aligning with the wider UX plan.

> [...] The aesthetics are orthogonal to the underlying search.

Agreed. I even think it's best if we land this now to force the UX redesign to take this into account.

review: Approve

« Back to merge proposal