Code review comment for lp:~julian-edwards/launchpad/trivial-ui

Revision history for this message
Julian Edwards (julian-edwards) wrote :

= Summary =
Fix a bunch of trivial ui issues

== Proposed fix ==
 * https://bugs.edge.launchpad.net/bugs/328402 - show the ppa's signing key
fingerprint
 * https://bugs.edge.launchpad.net/soyuz/+bug/57559 - everything's already
fixed apart from the last item which is to change a heading
 * https://bugs.edge.launchpad.net/bugs/131515 - Fix inconsistent titles on
some package-related pages
 * https://bugs.edge.launchpad.net/bugs/237263 - add (pending) at the end of a
diff title's text if it's not ready to download yet

== Implementation details ==
Pretty trivial changes, I even removed some template code that was filling
heading slots!

== Tests ==
Loads involved. I already tested with -t stories -t pagetests -t doc and
everything passes.

== Demo and Q/A ==
Run this in "psql launchpad_dev" so cprov's PPA gets a signing key:
update archive set signing_key=1 where id=9;

https://launchpad.dev/ubuntu/warty/+source/mozilla-firefox/0.9
https://launchpad.dev/ubuntu/+source/mozilla-firefox/0.9
https://dogfood.launchpad.net/~cprov/+archive/ppa
https://dogfood.launchpad.net/~cprov/+archive/ppa/+packages

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/model/distributionsourcepackagerelease.py
  lib/lp/soyuz/stories/ppa/xx-ubuntu-ppas.txt
  lib/lp/soyuz/browser/distroseriessourcepackagerelease.py
  lib/lp/registry/browser/sourcepackage.py
  lib/lp/soyuz/templates/sourcepackagerelease-diffs.pt
  lib/lp/soyuz/stories/soyuz/xx-package-diff.txt
  lib/lp/soyuz/templates/distroseriessourcepackagerelease-index.pt
  lib/lp/soyuz/stories/soyuz/xx-distributionsourcepackagerelease-pages.txt
  lib/lp/soyuz/templates/sourcepackagepublishinghistory-listing-archive-
extra.pt
  lib/lp/soyuz/templates/archive-index.pt
  lib/lp/soyuz/browser/distributionsourcepackagerelease.py
  lib/lp/soyuz/model/distroseriessourcepackagerelease.py
  lib/lp/soyuz/doc/package-meta-classes.txt
  lib/lp/soyuz/templates/distributionsourcepackagerelease-index.pt

== Pylint notices ==

lib/lp/soyuz/model/distributionsourcepackagerelease.py
    39: [F0401] Unable to import 'lazr.delegates' (No module named delegates)

lib/lp/soyuz/model/distroseriessourcepackagerelease.py
    27: [F0401] Unable to import 'lazr.delegates' (No module named delegates)

« Back to merge proposal