Code review comment for lp:~julian-edwards/launchpad/team-uploader-copy-packages-bug-445828

Revision history for this message
Julian Edwards (julian-edwards) wrote :

= Summary =
Allow third-party PPA uploaders copy access to a PPA when they have indirect
permissions via a team.

== Proposed fix ==
See bug https://bugs.edge.launchpad.net/soyuz/+bug/445828

When copying packages from a PPA, the drop-down list didn't include PPAs that
it should do if you were an indirect uploader by virtue of third-party
permissions on a team you're in.

== Pre-implementation notes ==
This is a trivial fix to join via TeamParticipation when needed.

== Implementation details ==
Because the archive.txt doctest was being particularly dense in relying on a
bunch of person names that were auto-generated by makePerson in the test
factory, I also had to make some other unrelated test fixes.

== Tests ==
bin/test -cvvt tests.*/doc/archive.txt

== Demo and Q/A ==
Dogfood FTW.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/doc/archive.txt
  lib/lp/soyuz/model/archive.py

== Pylint notices ==

lib/lp/soyuz/model/archive.py
    14: [F0401] Unable to import 'lazr.lifecycle.event' (No module named
lifecycle)

« Back to merge proposal