Code review comment for lp:~julian-edwards/launchpad/related-software-30

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Thanks for the review Michael!

On Tuesday 08 September 2009 16:21:12 Michael Nelson wrote:
> but basically, I'd remove the page_title view properties and either JDI or
> wait for barry's branch to land that will calculate the <title> page
> titles automatically.

The plan is to fix all our templates in one fell swoop when Barry's branch
lands. I don't think we should be blocking on that right now. I've attempted
to make it as easy as possible in all my branches to convert once it does
land, so in this case I just remove the heading slot in the template and it's
sorted. That's why I added page_title here and am using it manually. :)

Cheers
J

« Back to merge proposal