Launchpad itself

Code review comment for lp:~julian-edwards/launchpad/related-software-30

  1. related-software-30
  2. Merge into devel
Revision history for this message
Julian Edwards (julian-edwards) wrote :

= Summary =
Convert ~person/+related-software and associated pages to 3.0

Curtis has already approved the UI, I just need a secondary UI review and a
code review please!

== Pre-implementation notes ==
Chatted to Curtis about what to do with the 2nd level nav menus. We decided
to replace them with an <ul class="horizontal"> set of links instead. The
result looks better than expected!

== Implementation details ==
There are five templates converted, which are the +related-software page
itself and the 4 related pages for uploaded, maintained and PPA packages, and
related projects.

I also did some test cleaning by moving a test from the PPA stories (what the
heck was it doing there!) into the xx-person-related-software doctest. I also
removed unnecessary testing from the stories/foaf equivalent test since it was
just duplicating the soyuz story.

== Tests ==
bin/test -cvvt xx-person-related-software

== Demo and Q/A ==
https://launchpad.dev/~mark/+related-software
Click on the 4 links at the top to see the other pages.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/templates/person-ppa-packages.pt
  lib/canonical/launchpad/pagetitles.py
  lib/lp/soyuz/templates/person-maintained-packages.pt
  lib/lp/soyuz/templates/person-uploaded-packages.pt
  lib/lp/soyuz/stories/soyuz/xx-person-packages.txt
  lib/lp/registry/templates/person-related-software.pt
  lib/lp/registry/templates/person-related-projects.pt
  lib/lp/soyuz/stories/ppa/xx-ppa-navigation.txt
  lib/lp/registry/stories/foaf/xx-person-packages.txt
  lib/lp/registry/browser/person.py

== Pylint notices ==

lib/lp/registry/browser/person.py
    118: [F0401] Unable to import 'lazr.delegates' (No module named delegates)
    119: [F0401] Unable to import 'lazr.config' (No module named config)
    120: [F0401] Unable to import 'lazr.restful.interface' (No module named
restful)

« Back to merge proposal