Code review comment for lp:~julian-edwards/launchpad/publish-warning-bug-715116

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Tuesday 08 February 2011 18:36:10 you wrote:
> Review: Approve

Thanks for the review Leonard, and thanks for the critique of the wording.

> What do you think?

Much better, I've changed it a little more so it will look like:

            "Publishing has been disabled for this archive. (re-enable "
            "publishing) Since this archive is private, no builds are being "
            "dispatched."

> I also don't understand why "no builds are being dispatched" follows from
> "this archive is private". Why are builds dispatched for public archives
> that have publishing disabled? Will the actual users understand?

The reason for this is too technical to put on that page really, but the
upshot is that for security reasons the builders require authenticated access
to a place where they can download the source before building it. The only
place we have right now is the repo itself, thusly requiring the sources to be
published first.

The branch is in ec2 now, thanks.

« Back to merge proposal