Code review comment for lp:~julian-edwards/launchpad/publish-warning-bug-715116

Revision history for this message
Leonard Richardson (leonardr) wrote :

The code and tests look good but I think the wording has some problems. Let me nitpick your wording to try and save you a full UI review.

1. "Publishing has been disabled for this archive" is a full sentence and needs a period after it.

2. "Go to the Change details page..." is also a full sentence sentence.

3. Should "no builds will be dispatched" be "no builds are being dispatched"? Isn't it something that's (not) happening continuously, right now?

4. I'm not happy with the wording "Go to the Change details page", or with sticking a "Note:" in there with no special markup. How about one of these:

"Publishing has been disabled for this archive. Since this archive is private, no builds are being dispatched. You can <a>re-enable publishing</a>."

"Publishing has been disabled for this archive. <a>(Re-enable it.)</a> Since this archive is private, no builds are being dispatched."

What do you think?

I also don't understand why "no builds are being dispatched" follows from "this archive is private". Why are builds dispatched for public archives that have publishing disabled? Will the actual users understand?

review: Approve

« Back to merge proposal