Code review comment for lp:~julian-edwards/launchpad/publish-copy-archives-bug-520520-getPubConfig

Revision history for this message
Guilherme Salgado (salgado) wrote :

<salgado> bigjools, I was just wondering if it'd be possible to use a newly created distribution in that test, to have it not depending on any sample data
<bigjools> salgado: that would be quite a lot of work :/
<salgado> I imagined
<bigjools> the other tests in the file all do the same thing
<salgado> bigjools, do we need to have the suffixes hard-coded there? can't we take them from a constant somewhere?
<bigjools> salgado: that's the only place they will appear - is there a benefit to doing that?
<salgado> in that case, no

review: Approve (code)

« Back to merge proposal