Launchpad itself

Code review comment for lp:~julian-edwards/launchpad/publish-copy-archives-bug-520520-cron-job

  1. publish-copy-archives-bug-520520-cron-job
  2. Merge into devel
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hi Julian,

When I first looked at this, I was wondering why you don't define DISTRONAME earlier and then do:

ARCHIVEROOT=/srv/launchpad.net/DISTRONAME-archive/DISTRONAME

etc., but I see that it's the same in cron.publish-ftpmaster.

Also, another thing that's been inherited from the ftpmaster - the comment at the top about LPCONFIG coming from the environment so we can run it unaltered on dogfood, but then the check before copying indices that "$LPCONFIG" = "$PRODUCTION_CONFIG"... wouldn't we want to copy the indices on df?

I'm assuming this is what you've been testing like crazy on df yesterday...

15:00 < noodles> bigjools: this bash script - is it what you've been testing on df yesterday?
15:01 < bigjools> and today, yes

Great.

review: Approve (code)

« Back to merge proposal