Code review comment for lp:~julian-edwards/launchpad/ppa-expire-sources

Revision history for this message
Brad Crittenden (bac) wrote :

Hi Julian,

The branch looks good. You mentioned renaming the file but deferred due to time constraints. Seems like it would take 10 seconds so you might as well do it now. expire_ppa_resources.py ?

As far as refactoring the SQL it looks like you could use common aliases and then many of your comparisons would be the same, leaving you to just customize the WHERE clauses. Would that help? Or, if it was Storm-i-fied you may find it easier to refactor. Just two lame suggestions.

Otherwise your change looks very well done. Thanks.

review: Approve (code)

« Back to merge proposal