Launchpad itself

Code review comment for lp:~julian-edwards/launchpad/ppa-copy-to-main-bug-426163

  1. ppa-copy-to-main-bug-426163
  2. Merge into devel
Revision history for this message
Aaron Bentley (abentley) wrote :

This looks basically good, but there are a few things I'd like changed.

1. Please document the parameters of newBinaryPublication and newSourcePublication
2. Both methods take a status parameter which they ignore. Either they should not accept the parameter, or they should not ignore it. Celso suggests they should not accept the parameter
3. xx-queue-pages-delayed-copies.txt appears to reimplement canonical.launchpad.scripts.tests.run_script. If possible, please use run_script.

« Back to merge proposal