Merge lp:~julian-edwards/launchpad/missing-slave-method-bug-509383 into lp:launchpad
Proposed by
Julian Edwards
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp:~julian-edwards/launchpad/missing-slave-method-bug-509383 |
Merge into: | lp:launchpad |
Diff against target: |
107 lines (+28/-13) 5 files modified
lib/lp/buildmaster/manager.py (+4/-0) lib/lp/buildmaster/model/builder.py (+2/-2) lib/lp/buildmaster/tests/test_manager.py (+17/-6) lib/lp/soyuz/model/binarypackagebuildbehavior.py (+2/-2) lib/lp/soyuz/tests/soyuzbuilddhelpers.py (+3/-3) |
To merge this branch: | bzr merge lp:~julian-edwards/launchpad/missing-slave-method-bug-509383 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email:
|
To post a comment you must log in.
= Summary =
Add a method to RecordingSlave that was missed during refactoring
== Proposed fix ==
RecordingSlave is missing _sendFileToSlave(). This was missed out during the
refactoring at the Wellington sprint and causes private builds to fail.
== Implementation details == ensurepresent so the same test for
The new method just calls RecordingSlave.
that is re-used.
== Tests ==
bin/test -vvct TestRecordingSlaves
== Demo and Q/A ==
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: buildmaster/ model/builder. py buildmaster/ tests/test_ manager. py soyuz/tests/ soyuzbuilddhelp ers.py buildmaster/ manager. py soyuz/model/ binarypackagebu ildbehavior. py
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/