Code review comment for lp:~julian-edwards/launchpad/metadata-type-bug-595038
Revision history for this message
| Julian Edwards (julian-edwards) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Thanks for the review Jelmer.
I think CATALOGUE is another can of worms, because the US spelling is CATALOG. I also don't think changing the enum name itself will help a lot, to be honest, but the doctest and the enum text should be very clear and easy to understand. Is there anything in those you think can be improved?
J