Code review comment for lp:~julian-edwards/launchpad/disable-failures-bm-bug-676479

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

It's a pity that we need this, both because xmlrpc.Proxy should have its own timeout argument and because the slave really shouldn't take that long to respond. This seems like a reasonable way to deal with it for the moment though. Also, yay for more logging.

Two minor stylistic issues: the "from twisted.internet import ssl" on line 39 could be in the head of the file, and the 'd' variable should be longer according to our style guide.

review: Approve (code)

« Back to merge proposal