Code review comment for lp:~julian-edwards/launchpad/build-queue-sizes-bug-609904

Hi Julian,

I have a bit of difficulty reviewing this without domain-specific knowledge, so I'll trust you that the code is ok. But I did have a question about the tests.

You see, I'm a bit confused by the doc/ directory and the files within. When I am reading a documentation file I don't care what the 'virtualized' flag does, I just care that it exists. I also don't want to read the gritty details of how it behaves correctly when a certain bug is present (which is what the new doctest code is for). The implementation details and bugfix test should be off in a unit test somewhere.

So, is the doctest the right place to exercise the bugfix? What is the purpose of doc/builder.txt?

I'm marking this as 'Needs Information' for now.

Maris