Code review comment for lp:~julian-edwards/launchpad/archive-url-bug-520520

Revision history for this message
Julian Edwards (julian-edwards) wrote :

= Summary =
Fix archive_url for copy archives - it was missing the distribution name at
the end

== Proposed fix ==
The IArchive.archive_url property for "copy" archives was missing the
distribution name as the last path component.

== Pre-implementation notes ==
Error found during QA!

== Implementation details ==
It's a trivial change ...

== Tests ==
bin/test -cvvt archive.txt

== Demo and Q/A ==

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/doc/archive.txt
  lib/lp/soyuz/model/archive.py

== Pylint notices ==

lib/lp/soyuz/model/archive.py
    14: [F0401] Unable to import 'lazr.lifecycle.event' (No module named
lifecycle)

« Back to merge proposal