Code review comment for lp:~julian-edwards/gwacl/extra-putpage-checks

On 24/06/13 18:31, Gavin Panella wrote:
> Review: Approve
>
> Looks good. Couple of points.
>
>
> [1]
>
> + return fmt.Errorf("Size must be multiple of 512 bytes")
>
> *a* multiple?
>
> Here and in one other place.

Omitting prepositions is perfectly normal English, but I will assuage
your concerns.

>
>
> [2]
>
> + validStart := math.Mod(float64(req.StartRange), 512) == 0
>
> There is a % operator in Go:
>
> validStart := (req.StartRange % 512 == 0)
>

Feck. Sometimes you look past the bleedin' obvious when a language
teaches you that you can't rely on the obvious.

Thanks!