Code review comment for lp:~juju/txzookeeper/basic-node-api

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

[3] There's now an event object wrapping the watch callback values along with the node object.

[4] This is for sorting node collections, and is deterministic. It might be uintended in the node1 < node2 case. Alternative would be either providing a list compare function in the module, or letting users define one. Providing it on the class directly depends on how common the sorting nodes would be vs. confusion on other __cmp__ usages.

[5] All the implicit stuff has been yanked except the last version tracking. There is now an explicit create method on the node.

« Back to merge proposal