Merge lp:~juhapekka-piiroinen/ubuntu-qtcreator-plugins/fix-bug-1169831 into lp:ubuntu-qtcreator-plugins

Proposed by Juhapekka Piiroinen
Status: Merged
Merged at revision: 188
Proposed branch: lp:~juhapekka-piiroinen/ubuntu-qtcreator-plugins/fix-bug-1169831
Merge into: lp:ubuntu-qtcreator-plugins
Diff against target: 112 lines (+18/-0)
3 files modified
qtcreator/share/qtcreator/ubuntu/menu.json (+7/-0)
qtcreator/src/plugins/ubuntu/ubuntuconstants.h (+1/-0)
qtcreator/src/plugins/ubuntu/ubuntumenu.cpp (+10/-0)
To merge this branch: bzr merge lp:~juhapekka-piiroinen/ubuntu-qtcreator-plugins/fix-bug-1169831
Reviewer Review Type Date Requested Status
Ubuntu SDK team Pending
Review via email: mp+162523@code.launchpad.net

Commit message

Fix Bug #1169831: all edited files should be saved when Run on device is selected

Add support for saveRequired flag to menu.json.

Description of the change

Fix Bug #1169831: all edited files should be saved when Run on device is selected

Add support for saveRequired flag to menu.json.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'qtcreator/share/qtcreator/ubuntu/menu.json'
--- qtcreator/share/qtcreator/ubuntu/menu.json 2013-05-03 21:35:00 +0000
+++ qtcreator/share/qtcreator/ubuntu/menu.json 2013-05-04 21:44:23 +0000
@@ -13,6 +13,7 @@
13 "keysequence": "Ctrl+F12",13 "keysequence": "Ctrl+F12",
14 "deviceRequired": true,14 "deviceRequired": true,
15 "qmlProjectRequired": true,15 "qmlProjectRequired": true,
16 "saveRequired": true,
16 "actions": [17 "actions": [
17 "%SCRIPTDIRECTORY%/qtc_device_run_app %SERIALNUMBER% %FOLDERNAME% %DISPLAYNAME%.desktop %DISPLAYNAME%.qml /home/phablet/dev_tmp /home/phablet/.local/share/applications"18 "%SCRIPTDIRECTORY%/qtc_device_run_app %SERIALNUMBER% %FOLDERNAME% %DISPLAYNAME%.desktop %DISPLAYNAME%.qml /home/phablet/dev_tmp /home/phablet/.local/share/applications"
18 ]19 ]
@@ -33,6 +34,7 @@
33 "id": "Ubuntu.Build.Package",34 "id": "Ubuntu.Build.Package",
34 "workingDirectory": "%0",35 "workingDirectory": "%0",
35 "projectRequired": true,36 "projectRequired": true,
37 "saveRequired": true,
36 "actions": [38 "actions": [
37 "%SCRIPTDIRECTORY%/qtc_project_packaging .",39 "%SCRIPTDIRECTORY%/qtc_project_packaging .",
38 "%SCRIPTDIRECTORY%/qtc_project_debuild",40 "%SCRIPTDIRECTORY%/qtc_project_debuild",
@@ -46,6 +48,7 @@
46 "projectRequired": true,48 "projectRequired": true,
47 "deviceRequired": true,49 "deviceRequired": true,
48 "qmlProjectRequired": true,50 "qmlProjectRequired": true,
51 "saveRequired": true,
49 "actions": [52 "actions": [
50 "%SCRIPTDIRECTORY%/qtc_project_create_package",53 "%SCRIPTDIRECTORY%/qtc_project_create_package",
51 "%SCRIPTDIRECTORY%/qtc_device_deploy_package %SERIALNUMBER% ../%FOLDERNAME%*.deb phablet@127.0.0.1 2222 /home/phablet"54 "%SCRIPTDIRECTORY%/qtc_device_deploy_package %SERIALNUMBER% ../%FOLDERNAME%*.deb phablet@127.0.0.1 2222 /home/phablet"
@@ -58,6 +61,7 @@
58 "projectRequired": true,61 "projectRequired": true,
59 "deviceRequired": true,62 "deviceRequired": true,
60 "qmakeProjectRequired": true,63 "qmakeProjectRequired": true,
64 "saveRequired": true,
61 "actions": [65 "actions": [
62 "%SCRIPTDIRECTORY%/qtc_device_buildpackage %SERIALNUMBER% %FOLDERNAME%"66 "%SCRIPTDIRECTORY%/qtc_device_buildpackage %SERIALNUMBER% %FOLDERNAME%"
63 ]67 ]
@@ -69,6 +73,7 @@
69 "projectRequired": true,73 "projectRequired": true,
70 "deviceRequired": true,74 "deviceRequired": true,
71 "qmakeProjectRequired": true,75 "qmakeProjectRequired": true,
76 "saveRequired": true,
72 "actions": [77 "actions": [
73 "%SCRIPTDIRECTORY%/qtc_device_buildanddeploypackage %SERIALNUMBER% %FOLDERNAME%"78 "%SCRIPTDIRECTORY%/qtc_device_buildanddeploypackage %SERIALNUMBER% %FOLDERNAME%"
74 ]79 ]
@@ -142,6 +147,7 @@
142 "name": "Export \".pot\" File",147 "name": "Export \".pot\" File",
143 "id": "Ubuntu.Menu.i18n.pot",148 "id": "Ubuntu.Menu.i18n.pot",
144 "projectRequired": true,149 "projectRequired": true,
150 "saveRequired": true,
145 "actions": [151 "actions": [
146 "mkdir -p po",152 "mkdir -p po",
147 "xgettext -o po/%DISPLAYNAME%.pot --qt --c++ --add-comments=TRANSLATORS --keyword=tr %PROJECTFILES%"153 "xgettext -o po/%DISPLAYNAME%.pot --qt --c++ --add-comments=TRANSLATORS --keyword=tr %PROJECTFILES%"
@@ -151,6 +157,7 @@
151 "name": "Generate \".mo\" File",157 "name": "Generate \".mo\" File",
152 "id": "Ubuntu.Menu.i18n.mo",158 "id": "Ubuntu.Menu.i18n.mo",
153 "projectRequired": true,159 "projectRequired": true,
160 "saveRequired": true,
154 "actions": [161 "actions": [
155 "msgfmt po/*.po"162 "msgfmt po/*.po"
156 ]163 ]
157164
=== modified file 'qtcreator/src/plugins/ubuntu/ubuntuconstants.h'
--- qtcreator/src/plugins/ubuntu/ubuntuconstants.h 2013-05-03 23:00:15 +0000
+++ qtcreator/src/plugins/ubuntu/ubuntuconstants.h 2013-05-04 21:44:23 +0000
@@ -57,6 +57,7 @@
57const char UBUNTU_MENUJSON_DEVICEREQUIRED[] = "deviceRequired";57const char UBUNTU_MENUJSON_DEVICEREQUIRED[] = "deviceRequired";
58const char UBUNTU_MENUJSON_QMLPROJECTREQUIRED[] = "qmlProjectRequired";58const char UBUNTU_MENUJSON_QMLPROJECTREQUIRED[] = "qmlProjectRequired";
59const char UBUNTU_MENUJSON_QMAKEPROJECTREQUIRED[] = "qmakeProjectRequired";59const char UBUNTU_MENUJSON_QMAKEPROJECTREQUIRED[] = "qmakeProjectRequired";
60const char UBUNTU_MENUJSON_SAVEREQUIRED[] = "saveRequired";
60const char UBUNTU_MENUJSON_MESSAGEDIALOG[] = "messageDialog";61const char UBUNTU_MENUJSON_MESSAGEDIALOG[] = "messageDialog";
6162
62const char UBUNTU_MENUJSON_PARENT_TOOLS[] = "Tools";63const char UBUNTU_MENUJSON_PARENT_TOOLS[] = "Tools";
6364
=== modified file 'qtcreator/src/plugins/ubuntu/ubuntumenu.cpp'
--- qtcreator/src/plugins/ubuntu/ubuntumenu.cpp 2013-05-01 18:28:10 +0000
+++ qtcreator/src/plugins/ubuntu/ubuntumenu.cpp 2013-05-04 21:44:23 +0000
@@ -160,6 +160,7 @@
160 bool actionDeviceRequired = false;160 bool actionDeviceRequired = false;
161 bool actionQmlProjectRequired = false;161 bool actionQmlProjectRequired = false;
162 bool actionQmakeProjectRequired = false;162 bool actionQmakeProjectRequired = false;
163 bool actionSaveRequired = false;
163164
164 if (obj.contains(QLatin1String(Constants::UBUNTU_MENUJSON_NAME))) {165 if (obj.contains(QLatin1String(Constants::UBUNTU_MENUJSON_NAME))) {
165 actionName = obj.value(QLatin1String(Constants::UBUNTU_MENUJSON_NAME)).toString();166 actionName = obj.value(QLatin1String(Constants::UBUNTU_MENUJSON_NAME)).toString();
@@ -185,6 +186,9 @@
185 if (obj.contains(QLatin1String(Constants::UBUNTU_MENUJSON_QMAKEPROJECTREQUIRED))) {186 if (obj.contains(QLatin1String(Constants::UBUNTU_MENUJSON_QMAKEPROJECTREQUIRED))) {
186 actionQmakeProjectRequired = obj.value(QLatin1String(Constants::UBUNTU_MENUJSON_QMAKEPROJECTREQUIRED)).toBool();187 actionQmakeProjectRequired = obj.value(QLatin1String(Constants::UBUNTU_MENUJSON_QMAKEPROJECTREQUIRED)).toBool();
187 }188 }
189 if (obj.contains(QLatin1String(Constants::UBUNTU_MENUJSON_SAVEREQUIRED))) {
190 actionSaveRequired = obj.value(QLatin1String(Constants::UBUNTU_MENUJSON_SAVEREQUIRED)).toBool();
191 }
188192
189 if (obj.contains(QLatin1String(Constants::UBUNTU_MENUJSON_ACTIONS)) && obj.value(QLatin1String(Constants::UBUNTU_MENUJSON_ACTIONS)).isArray()) {193 if (obj.contains(QLatin1String(Constants::UBUNTU_MENUJSON_ACTIONS)) && obj.value(QLatin1String(Constants::UBUNTU_MENUJSON_ACTIONS)).isArray()) {
190194
@@ -213,6 +217,7 @@
213 act->setProperty(Constants::UBUNTU_MENUJSON_DEVICEREQUIRED,actionDeviceRequired);217 act->setProperty(Constants::UBUNTU_MENUJSON_DEVICEREQUIRED,actionDeviceRequired);
214 act->setProperty(Constants::UBUNTU_MENUJSON_QMAKEPROJECTREQUIRED,actionQmakeProjectRequired);218 act->setProperty(Constants::UBUNTU_MENUJSON_QMAKEPROJECTREQUIRED,actionQmakeProjectRequired);
215 act->setProperty(Constants::UBUNTU_MENUJSON_QMLPROJECTREQUIRED,actionQmlProjectRequired);219 act->setProperty(Constants::UBUNTU_MENUJSON_QMLPROJECTREQUIRED,actionQmlProjectRequired);
220 act->setProperty(Constants::UBUNTU_MENUJSON_SAVEREQUIRED,actionSaveRequired);
216221
217 connect(act, SIGNAL(triggered()), this, SLOT(menuItemTriggered()));222 connect(act, SIGNAL(triggered()), this, SLOT(menuItemTriggered()));
218 m_actions.append(act);223 m_actions.append(act);
@@ -246,6 +251,11 @@
246 }251 }
247 }252 }
248253
254 QVariant saveModifiedFilesRequired = act->property(Constants::UBUNTU_MENUJSON_SAVEREQUIRED);
255 if (saveModifiedFilesRequired.isValid() && saveModifiedFilesRequired.toBool()==true) {
256 ProjectExplorer::ProjectExplorerPlugin::instance()->saveModifiedFiles();
257 }
258
249 if (m_commandMap.contains(act->text())) {259 if (m_commandMap.contains(act->text())) {
250 QJsonValueList actions = m_commandMap.value(act->text());260 QJsonValueList actions = m_commandMap.value(act->text());
251261

Subscribers

People subscribed via source and target branches